On pull requests... progress

Good day!

Wishing to follow the traditions of development and the code of conduct, what are my actions on PR staling?

One of it was closed by @github-actions bot without any comment.

There is another one

Thanks.

Thanks for creating these PRs!
I think the PRs lack a bit of explanation and what exactly is being improved.
E.g. in #136218 you change the assignment to a comparison:

At groups == 1

but why was the previous code unclear, misleading, or wrong? (I’m not saying your change is invalid, but also don’t see why the current docs are wrong.)

@ptrblck , thanks for the reply!
Mostly both PRs add or fix highlighting of attrs/arguments in the (generated) documentation.
If I find some content changes, I’ll write there.

The first PR has been reborn.

The second PR has been merged.

1 Like